[Webkit-unassigned] [Bug 161481] [GTK] Use GTestDBus instead of dbus-launch in WebKitTestBus.cpp
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 2 08:36:19 PDT 2016
https://bugs.webkit.org/show_bug.cgi?id=161481
Michael Catanzaro <mcatanzaro at igalia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #293416|review? |review+
Flags| |
--- Comment #15 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 293416
--> https://bugs.webkit.org/attachment.cgi?id=293416
Patch
I'm going to give you r+ since you've convinced me that the current code is safe, but I really do think this is fragile and that it would be better to add an assertion, even if the assertion is not straightforward to write.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161102/c6bbe80d/attachment.html>
More information about the webkit-unassigned
mailing list