<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Use GTestDBus instead of dbus-launch in WebKitTestBus.cpp"
href="https://bugs.webkit.org/show_bug.cgi?id=161481#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Use GTestDBus instead of dbus-launch in WebKitTestBus.cpp"
href="https://bugs.webkit.org/show_bug.cgi?id=161481">bug 161481</a>
from <span class="vcard"><a class="email" href="mailto:gns@gnome.org" title="Gustavo Noronha (kov) <gns@gnome.org>"> <span class="fn">Gustavo Noronha (kov)</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=161481#c11">comment #11</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=161481#c9">comment #9</a>)
> > While the patch from <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Use dbus-run-session when possible to avoid left-over dbus-daemon instances"
href="show_bug.cgi?id=161135">bug 161135</a> applies along with this one, it does disable
> > this one which I think is undesirable. The result of having both applied
> > would be dbus-run-session be used every time it is available. This solution
> > is a better one, so I'd recommend just going with it, if we can fix the
> > threading concerns.
>
> I'm not sure this patch solves the same problem. The bus started by
> WebKitTestBus::run() will be leaked if the test crashes, because
> ~WebKitTestBus() won't be called in that case. So, we can leave this code as
> fallback when dbus-run-session is not present, or when tests are run
> manually (without using run-gtk-tests), something that I do a lot. When
> dbus-run-session is present we simply set m_address, I don't think the
> patches are mutually exclusive.</span >
I thought GTestDBus handled cleaning up the dbus daemon process even on crashes? But if you think it's useful to have both and ok to have dbus-run-session used when present I'll go ahead and land it =)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>