[Webkit-unassigned] [Bug 155795] [JSC] implement String.prototype.padStart() and String.prototype.padEnd() proposal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 25 08:36:12 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=155795

--- Comment #17 from Darin Adler <darin at apple.com> ---
Comment on attachment 274904
  --> https://bugs.webkit.org/attachment.cgi?id=274904
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274904&action=review

>>> Source/JavaScriptCore/runtime/StringPrototype.cpp:903
>>> +        UChar character = filler ? filler->view(&exec)[0] : ' ';
>> 
>> This should use the unsafeView function for better efficiency rather than the view function.
> 
> `unsafeView()` is private --- would you prefer making it public, moving `padString` to the JSString class, or adding it as a friend?

OK, my mistake. OK to use view.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160325/37bbabfe/attachment-0001.html>


More information about the webkit-unassigned mailing list