<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] implement String.prototype.padStart() and String.prototype.padEnd() proposal"
href="https://bugs.webkit.org/show_bug.cgi?id=155795#c17">Comment # 17</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] implement String.prototype.padStart() and String.prototype.padEnd() proposal"
href="https://bugs.webkit.org/show_bug.cgi?id=155795">bug 155795</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=274904&action=diff" name="attach_274904" title="Patch">attachment 274904</a> <a href="attachment.cgi?id=274904&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=274904&action=review">https://bugs.webkit.org/attachment.cgi?id=274904&action=review</a>
<span class="quote">>>> Source/JavaScriptCore/runtime/StringPrototype.cpp:903
>>> + UChar character = filler ? filler->view(&exec)[0] : ' ';
>>
>> This should use the unsafeView function for better efficiency rather than the view function.
>
> `unsafeView()` is private --- would you prefer making it public, moving `padString` to the JSString class, or adding it as a friend?</span >
OK, my mistake. OK to use view.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>