[Webkit-unassigned] [Bug 155795] [JSC] implement String.prototype.padStart() and String.prototype.padEnd() proposal

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155795

--- Comment #16 from Caitlin Potter (:caitp) <caitp at igalia.com> ---
Comment on attachment 274904
  --> https://bugs.webkit.org/attachment.cgi?id=274904
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274904&action=review

>> Source/JavaScriptCore/runtime/StringPrototype.cpp:903
>> +        UChar character = filler ? filler->view(&exec)[0] : ' ';
> 
> This should use the unsafeView function for better efficiency rather than the view function.

`unsafeView()` is private --- would you prefer making it public, moving `padString` to the JSString class, or adding it as a friend?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160325/cffcb4a2/attachment.html>