[Webkit-unassigned] [Bug 155771] Add machine-readable results for JSC stress tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155771

--- Comment #3 from Sri Vijayaraghavan <svijayaraghavan at apple.com> ---
(In reply to comment #2)
> Comment on attachment 274690 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=274690&action=review
> 
> LGTM otherwise!
> 
> > Tools/Scripts/run-javascriptcore-tests:71
> > +my $jsonFileName = "jsc.json";
> 
> Can we come up with a better name for this? Maybe "jsc_test_failures.json"

Yup, we could do that. Alternatively, what do you think of having the filename being a command-line parameter? So the option could be something like --json-output="<filename>". This would require taking care of relative paths (there are functions in the webkitdirs.pm module which might help with that).

> 
> > Tools/Scripts/run-javascriptcore-tests:334
> > +        my $json_string = encode_json \%json_data;
> 
> This should probably be jsonString, so we follow the same naming conventions
> as other variables in the file.
My bad. Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160322/e1413b22/attachment.html>