<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add machine-readable results for JSC stress tests"
href="https://bugs.webkit.org/show_bug.cgi?id=155771#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add machine-readable results for JSC stress tests"
href="https://bugs.webkit.org/show_bug.cgi?id=155771">bug 155771</a>
from <span class="vcard"><a class="email" href="mailto:svijayaraghavan@apple.com" title="Sri Vijayaraghavan <svijayaraghavan@apple.com>"> <span class="fn">Sri Vijayaraghavan</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=155771#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=274690&action=diff" name="attach_274690" title="Patch">attachment 274690</a> <a href="attachment.cgi?id=274690&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=274690&action=review">https://bugs.webkit.org/attachment.cgi?id=274690&action=review</a>
>
> LGTM otherwise!
>
> > Tools/Scripts/run-javascriptcore-tests:71
> > +my $jsonFileName = "jsc.json";
>
> Can we come up with a better name for this? Maybe "jsc_test_failures.json"</span >
Yup, we could do that. Alternatively, what do you think of having the filename being a command-line parameter? So the option could be something like --json-output="<filename>". This would require taking care of relative paths (there are functions in the webkitdirs.pm module which might help with that).
<span class="quote">>
> > Tools/Scripts/run-javascriptcore-tests:334
> > + my $json_string = encode_json \%json_data;
>
> This should probably be jsonString, so we follow the same naming conventions
> as other variables in the file.</span >
My bad. Thanks!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>