[Webkit-unassigned] [Bug 155771] Add machine-readable results for JSC stress tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 22 16:08:09 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=155771

--- Comment #2 from Dean Johnson <dean_johnson at apple.com> ---
Comment on attachment 274690
  --> https://bugs.webkit.org/attachment.cgi?id=274690
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274690&action=review

LGTM otherwise!

> Tools/Scripts/run-javascriptcore-tests:71
> +my $jsonFileName = "jsc.json";

Can we come up with a better name for this? Maybe "jsc_test_failures.json"

> Tools/Scripts/run-javascriptcore-tests:334
> +        my $json_string = encode_json \%json_data;

This should probably be jsonString, so we follow the same naming conventions as other variables in the file.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160322/2b4d8e40/attachment.html>


More information about the webkit-unassigned mailing list