<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add machine-readable results for JSC stress tests"
href="https://bugs.webkit.org/show_bug.cgi?id=155771#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add machine-readable results for JSC stress tests"
href="https://bugs.webkit.org/show_bug.cgi?id=155771">bug 155771</a>
from <span class="vcard"><a class="email" href="mailto:dean_johnson@apple.com" title="Dean Johnson <dean_johnson@apple.com>"> <span class="fn">Dean Johnson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=274690&action=diff" name="attach_274690" title="Patch">attachment 274690</a> <a href="attachment.cgi?id=274690&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=274690&action=review">https://bugs.webkit.org/attachment.cgi?id=274690&action=review</a>
LGTM otherwise!
<span class="quote">> Tools/Scripts/run-javascriptcore-tests:71
> +my $jsonFileName = "jsc.json";</span >
Can we come up with a better name for this? Maybe "jsc_test_failures.json"
<span class="quote">> Tools/Scripts/run-javascriptcore-tests:334
> + my $json_string = encode_json \%json_data;</span >
This should probably be jsonString, so we follow the same naming conventions as other variables in the file.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>