[Webkit-unassigned] [Bug 155560] [JSC] allow duplicate property names returned from Proxy ownKeys() trap

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155560

--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 274222
  --> https://bugs.webkit.org/attachment.cgi?id=274222
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274222&action=review

>> Source/JavaScriptCore/runtime/ProxyObject.cpp:879
>> +        trapResult.addKnownUnique(ident.impl());
> 
> LGTM, but I think it's worth renaming "addKnownUnique"
> That functions name has lost its meaning over time. Either in
> this patch or another patch.

I completely agree. I came here just to write this comment!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160317/d2ea28f2/attachment.html>