[Webkit-unassigned] [Bug 155560] [JSC] allow duplicate property names returned from Proxy ownKeys() trap

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 17 02:20:18 PDT 2016


Saam Barati <sbarati at apple.com> changed:

           What    |Removed                     |Added
 Attachment #274222|review?                     |review+
              Flags|                            |

--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 274222
  --> https://bugs.webkit.org/attachment.cgi?id=274222

View in context: https://bugs.webkit.org/attachment.cgi?id=274222&action=review

> Source/JavaScriptCore/runtime/ProxyObject.cpp:879
> +        trapResult.addKnownUnique(ident.impl());

LGTM, but I think it's worth renaming "addKnownUnique"
That functions name has lost its meaning over time. Either in
this patch or another patch.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160317/50000090/attachment.html>

More information about the webkit-unassigned mailing list