<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] allow duplicate property names returned from Proxy ownKeys() trap"
href="https://bugs.webkit.org/show_bug.cgi?id=155560#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] allow duplicate property names returned from Proxy ownKeys() trap"
href="https://bugs.webkit.org/show_bug.cgi?id=155560">bug 155560</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=274222&action=diff" name="attach_274222" title="Patch">attachment 274222</a> <a href="attachment.cgi?id=274222&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=274222&action=review">https://bugs.webkit.org/attachment.cgi?id=274222&action=review</a>
<span class="quote">>> Source/JavaScriptCore/runtime/ProxyObject.cpp:879
>> + trapResult.addKnownUnique(ident.impl());
>
> LGTM, but I think it's worth renaming "addKnownUnique"
> That functions name has lost its meaning over time. Either in
> this patch or another patch.</span >
I completely agree. I came here just to write this comment!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>