[Webkit-unassigned] [Bug 154976] AX: Implement bounds/position and index related text marker functions using TextIterator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154976

--- Comment #7 from Nan Wang <n_wang at apple.com> ---
Comment on attachment 273256
  --> https://bugs.webkit.org/attachment.cgi?id=273256
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273256&action=review

>> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3983
>> +            IntRect webCoreRect = [self screenToContents:enclosingIntRect(rect)];
> 
> this is the same exact code for StartText and EndText... is that correct? if so can we combine

cache->characterOffsetForBounds(webCoreRect, true) has a boolean parameter to check if it's start or end.

>> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:4064
>> +        if (!cache)
> 
> it feels like we should put
> 
> AXObjectCache* cache = m_object->axObjectCache();
>  4064        if (!cache)
> 
> near the top of this accessibilityAttributeValue: method so that we don't have to do all these checks
> 
> if an object does not have a cache it seems OK to return nil values for it

Ok, I'll double check.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160309/11a68d78/attachment.html>