<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Implement bounds/position and index related text marker functions using TextIterator"
href="https://bugs.webkit.org/show_bug.cgi?id=154976#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Implement bounds/position and index related text marker functions using TextIterator"
href="https://bugs.webkit.org/show_bug.cgi?id=154976">bug 154976</a>
from <span class="vcard"><a class="email" href="mailto:n_wang@apple.com" title="Nan Wang <n_wang@apple.com>"> <span class="fn">Nan Wang</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=273256&action=diff" name="attach_273256" title="patch">attachment 273256</a> <a href="attachment.cgi?id=273256&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=273256&action=review">https://bugs.webkit.org/attachment.cgi?id=273256&action=review</a>
<span class="quote">>> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3983
>> + IntRect webCoreRect = [self screenToContents:enclosingIntRect(rect)];
>
> this is the same exact code for StartText and EndText... is that correct? if so can we combine</span >
cache->characterOffsetForBounds(webCoreRect, true) has a boolean parameter to check if it's start or end.
<span class="quote">>> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:4064
>> + if (!cache)
>
> it feels like we should put
>
> AXObjectCache* cache = m_object->axObjectCache();
> 4064 if (!cache)
>
> near the top of this accessibilityAttributeValue: method so that we don't have to do all these checks
>
> if an object does not have a cache it seems OK to return nil values for it</span >
Ok, I'll double check.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>