[Webkit-unassigned] [Bug 154976] AX: Implement bounds/position and index related text marker functions using TextIterator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154976

chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #273256|review?                     |review+
              Flags|                            |

--- Comment #6 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 273256
  --> https://bugs.webkit.org/attachment.cgi?id=273256
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273256&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:2352
> +    RenderObject* renderer;

i would initialize this to nullptr just to be safe

> Source/WebCore/accessibility/AXObjectCache.cpp:2374
> +

extra line not necessary

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3983
> +            IntRect webCoreRect = [self screenToContents:enclosingIntRect(rect)];

this is the same exact code for StartText and EndText... is that correct? if so can we combine

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:4064
> +        if (!cache)

it feels like we should put

AXObjectCache* cache = m_object->axObjectCache();
 4064        if (!cache)

near the top of this accessibilityAttributeValue: method so that we don't have to do all these checks

if an object does not have a cache it seems OK to return nil values for it

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160309/9f1787fc/attachment.html>