<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cfleizach@apple.com" title="chris fleizach <cfleizach@apple.com>"> <span class="fn">chris fleizach</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Implement bounds/position and index related text marker functions using TextIterator"
href="https://bugs.webkit.org/show_bug.cgi?id=154976">bug 154976</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #273256 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Implement bounds/position and index related text marker functions using TextIterator"
href="https://bugs.webkit.org/show_bug.cgi?id=154976#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Implement bounds/position and index related text marker functions using TextIterator"
href="https://bugs.webkit.org/show_bug.cgi?id=154976">bug 154976</a>
from <span class="vcard"><a class="email" href="mailto:cfleizach@apple.com" title="chris fleizach <cfleizach@apple.com>"> <span class="fn">chris fleizach</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=273256&action=diff" name="attach_273256" title="patch">attachment 273256</a> <a href="attachment.cgi?id=273256&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=273256&action=review">https://bugs.webkit.org/attachment.cgi?id=273256&action=review</a>
<span class="quote">> Source/WebCore/accessibility/AXObjectCache.cpp:2352
> + RenderObject* renderer;</span >
i would initialize this to nullptr just to be safe
<span class="quote">> Source/WebCore/accessibility/AXObjectCache.cpp:2374
> +</span >
extra line not necessary
<span class="quote">> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3983
> + IntRect webCoreRect = [self screenToContents:enclosingIntRect(rect)];</span >
this is the same exact code for StartText and EndText... is that correct? if so can we combine
<span class="quote">> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:4064
> + if (!cache)</span >
it feels like we should put
AXObjectCache* cache = m_object->axObjectCache();
4064 if (!cache)
near the top of this accessibilityAttributeValue: method so that we don't have to do all these checks
if an object does not have a cache it seems OK to return nil values for it</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>