[Webkit-unassigned] [Bug 155056] AX: Force allow user zoom

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155056

--- Comment #5 from Nan Wang <n_wang at apple.com> ---
Comment on attachment 273066
  --> https://bugs.webkit.org/attachment.cgi?id=273066
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273066&action=review

Will address other comments.

>> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:214
>> +#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 100000
> 
> #if PLATFORM(IOS) &&

the above includes are already in #if PLATFORM(IOS)

>> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2820
>> +    m_viewportConfiguration.setForceAlwaysUserScalable(_AXSForceAllowWebScaling());
> 
> it seems like this should also respect
> store.getBoolValueForKey(WebPreferencesKey::forceAlwaysUserScalableKey());
> 
> maybe this method should have all the logic and then updatePreferences below calls updateForceAlways..()

In this case we should cache store.getBoolValueForKey(WebPreferencesKey::forceAlwaysUserScalableKey()) somewhere? When we get a notification we don't have access to the store object.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160305/31b0a322/attachment.html>