[Webkit-unassigned] [Bug 155056] AX: Force allow user zoom

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155056

--- Comment #4 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 273066
  --> https://bugs.webkit.org/attachment.cgi?id=273066
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273066&action=review

> Source/WebCore/ChangeLog:10
> +        No new tests.

we should probably add a test that override force scale (which can be set with Settings in the layout test) also overrides max scale

> Source/WebCore/page/ViewportConfiguration.h:91
> +    double maximumScale() const { return m_forceAlwaysUserScalable ? 10.0 : m_configuration.maximumScale; }

we should probably define this is a const double somewhere

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:214
> +#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 100000

#if PLATFORM(IOS) &&

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:215
> +#include <WebCore/SoftLinking.h>

i think you need another #if
#if __has_include(<AccessibilitySupport.h>)
#else
extern "C" {
Boolean _AXSForceAllowWebScaling();
CFStringRef kAXSAllowForceWebScalingEnabledNotification;
}
#endif

so that this can be built by other people

take a look at WeakObjCPtr.h

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:602
> +    CFNotificationCenterRemoveObserver(CFNotificationCenterGetLocalCenter(), this, 0, 0);

nullptr, nullptr

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2820
> +    m_viewportConfiguration.setForceAlwaysUserScalable(_AXSForceAllowWebScaling());

it seems like this should also respect
store.getBoolValueForKey(WebPreferencesKey::forceAlwaysUserScalableKey());

maybe this method should have all the logic and then updatePreferences below calls updateForceAlways..()

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160305/966ddb2f/attachment.html>