<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Force allow user zoom"
href="https://bugs.webkit.org/show_bug.cgi?id=155056#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Force allow user zoom"
href="https://bugs.webkit.org/show_bug.cgi?id=155056">bug 155056</a>
from <span class="vcard"><a class="email" href="mailto:n_wang@apple.com" title="Nan Wang <n_wang@apple.com>"> <span class="fn">Nan Wang</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=273066&action=diff" name="attach_273066" title="patch">attachment 273066</a> <a href="attachment.cgi?id=273066&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=273066&action=review">https://bugs.webkit.org/attachment.cgi?id=273066&action=review</a>
Will address other comments.
<span class="quote">>> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:214
>> +#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 100000
>
> #if PLATFORM(IOS) &&</span >
the above includes are already in #if PLATFORM(IOS)
<span class="quote">>> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2820
>> + m_viewportConfiguration.setForceAlwaysUserScalable(_AXSForceAllowWebScaling());
>
> it seems like this should also respect
> store.getBoolValueForKey(WebPreferencesKey::forceAlwaysUserScalableKey());
>
> maybe this method should have all the logic and then updatePreferences below calls updateForceAlways..()</span >
In this case we should cache store.getBoolValueForKey(WebPreferencesKey::forceAlwaysUserScalableKey()) somewhere? When we get a notification we don't have access to the store object.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>