<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Force allow user zoom"
href="https://bugs.webkit.org/show_bug.cgi?id=155056#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Force allow user zoom"
href="https://bugs.webkit.org/show_bug.cgi?id=155056">bug 155056</a>
from <span class="vcard"><a class="email" href="mailto:cfleizach@apple.com" title="chris fleizach <cfleizach@apple.com>"> <span class="fn">chris fleizach</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=273066&action=diff" name="attach_273066" title="patch">attachment 273066</a> <a href="attachment.cgi?id=273066&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=273066&action=review">https://bugs.webkit.org/attachment.cgi?id=273066&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:10
> + No new tests.</span >
we should probably add a test that override force scale (which can be set with Settings in the layout test) also overrides max scale
<span class="quote">> Source/WebCore/page/ViewportConfiguration.h:91
> + double maximumScale() const { return m_forceAlwaysUserScalable ? 10.0 : m_configuration.maximumScale; }</span >
we should probably define this is a const double somewhere
<span class="quote">> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:214
> +#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 100000</span >
#if PLATFORM(IOS) &&
<span class="quote">> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:215
> +#include <WebCore/SoftLinking.h></span >
i think you need another #if
#if __has_include(<AccessibilitySupport.h>)
#else
extern "C" {
Boolean _AXSForceAllowWebScaling();
CFStringRef kAXSAllowForceWebScalingEnabledNotification;
}
#endif
so that this can be built by other people
take a look at WeakObjCPtr.h
<span class="quote">> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:602
> + CFNotificationCenterRemoveObserver(CFNotificationCenterGetLocalCenter(), this, 0, 0);</span >
nullptr, nullptr
<span class="quote">> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2820
> + m_viewportConfiguration.setForceAlwaysUserScalable(_AXSForceAllowWebScaling());</span >
it seems like this should also respect
store.getBoolValueForKey(WebPreferencesKey::forceAlwaysUserScalableKey());
maybe this method should have all the logic and then updatePreferences below calls updateForceAlways..()</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>