[Webkit-unassigned] [Bug 159144] Too much duplicated code in LayerTreeHosts implementations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159144

--- Comment #5 from Gwang Yoon Hwang <yoon at igalia.com> ---
Comment on attachment 282123
  --> https://bugs.webkit.org/attachment.cgi?id=282123
Try to fix EFL build

View in context: https://bugs.webkit.org/attachment.cgi?id=282123&action=review

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:207
> +    UNUSED_PARAM(size);

Maybe using ASSERT_NOT_REACHED would be nice to use here.

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:65
> +    class CompositorClient final : public ThreadedCompositor::Client {

What about to add WTF_MAKE_NONCOPYABLE to make sure?

> Source/WebKit2/WebProcess/WebPage/LayerTreeHost.h:73
>      virtual void sizeDidChange(const WebCore::IntSize& newSize) = 0;

What about change the name of it to the viewportSizeChanged, as we discussed earlier?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160628/35a12392/attachment-0001.html>