[Webkit-unassigned] [Bug 159042] 'webkit-patch land' puts an inferred Reviewed By line between the bugzilla and radar links

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 23 11:38:44 PDT 2016


Brian Burg <bburg at apple.com> changed:

           What    |Removed                     |Added
                 CC|                            |bburg at apple.com

--- Comment #2 from Brian Burg <bburg at apple.com> ---
(In reply to comment #1)
> Note for future self:  This may (or may not) be related to the fact that
> both patches had the same first 4 or 5 lines before landing:
> +2016-06-22  Brian Burg  <bburg at apple.com>
> +
> +        Web Inspector: don't start auto capturing if the Inspector window
> is not visible
> +        https://bugs.webkit.org/show_bug.cgi?id=159014
> +        <rdar://problem/26931269>
> I know prepare-ChangeLog has issues "fixing up" patches where the added
> lines in ChangeLog files are offset from Line 1 because the title and bug
> are identical, so this may be a similar issue.
> This will also be fixed by switching to git, using commit-log-editor for
> commit messages, and then getting rid of ChangeLog files.  :)
> Brian, what was the exact "webkit-patch land" command you used when
> committing, and what state was your local repository in?  Had you just
> committed r202352?  Did you svn-update/git-svn-rebase your repo between
> commits?

I used `webkit-patch land` for the original patch. I don't remember if it was with -g head or no arguments, but I usually make a local commit and `git svn rebase` it myself.

For the follow-up patch, I didn't make a local commit, nor did I update/rebase.

> The exact sequence of steps to land the two patches would be useful here to
> try to reproduce.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160623/b47ab082/attachment.html>

More information about the webkit-unassigned mailing list