<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:bburg@apple.com" title="Brian Burg <bburg@apple.com>"> <span class="fn">Brian Burg</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - 'webkit-patch land' puts an inferred Reviewed By line between the bugzilla and radar links"
href="https://bugs.webkit.org/show_bug.cgi?id=159042">bug 159042</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>bburg@apple.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - 'webkit-patch land' puts an inferred Reviewed By line between the bugzilla and radar links"
href="https://bugs.webkit.org/show_bug.cgi?id=159042#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - 'webkit-patch land' puts an inferred Reviewed By line between the bugzilla and radar links"
href="https://bugs.webkit.org/show_bug.cgi?id=159042">bug 159042</a>
from <span class="vcard"><a class="email" href="mailto:bburg@apple.com" title="Brian Burg <bburg@apple.com>"> <span class="fn">Brian Burg</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=159042#c1">comment #1</a>)
<span class="quote">> Note for future self: This may (or may not) be related to the fact that
> both patches had the same first 4 or 5 lines before landing:
>
> +2016-06-22 Brian Burg <<a href="mailto:bburg@apple.com">bburg@apple.com</a>>
> +
> + Web Inspector: don't start auto capturing if the Inspector window
> is not visible
> + <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Web Inspector: don't start auto capturing if the Inspector window is not visible"
href="show_bug.cgi?id=159014">https://bugs.webkit.org/show_bug.cgi?id=159014</a>
> + <rdar://problem/26931269>
>
> I know prepare-ChangeLog has issues "fixing up" patches where the added
> lines in ChangeLog files are offset from Line 1 because the title and bug
> are identical, so this may be a similar issue.
>
> This will also be fixed by switching to git, using commit-log-editor for
> commit messages, and then getting rid of ChangeLog files. :)
>
> Brian, what was the exact "webkit-patch land" command you used when
> committing, and what state was your local repository in? Had you just
> committed r202352? Did you svn-update/git-svn-rebase your repo between
> commits?</span >
I used `webkit-patch land` for the original patch. I don't remember if it was with -g head or no arguments, but I usually make a local commit and `git svn rebase` it myself.
For the follow-up patch, I didn't make a local commit, nor did I update/rebase.
<span class="quote">> The exact sequence of steps to land the two patches would be useful here to
> try to reproduce.</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>