[Webkit-unassigned] [Bug 159042] 'webkit-patch land' puts an inferred Reviewed By line between the bugzilla and radar links

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 23 11:32:39 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=159042

--- Comment #1 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Note for future self:  This may (or may not) be related to the fact that both patches had the same first 4 or 5 lines before landing:

+2016-06-22  Brian Burg  <bburg at apple.com>
+
+        Web Inspector: don't start auto capturing if the Inspector window is not visible
+        https://bugs.webkit.org/show_bug.cgi?id=159014
+        <rdar://problem/26931269>

I know prepare-ChangeLog has issues "fixing up" patches where the added lines in ChangeLog files are offset from Line 1 because the title and bug are identical, so this may be a similar issue.

This will also be fixed by switching to git, using commit-log-editor for commit messages, and then getting rid of ChangeLog files.  :)

Brian, what was the exact "webkit-patch land" command you used when committing, and what state was your local repository in?  Had you just committed r202352?  Did you svn-update/git-svn-rebase your repo between commits?

The exact sequence of steps to land the two patches would be useful here to try to reproduce.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160623/a57b018f/attachment.html>


More information about the webkit-unassigned mailing list