[Webkit-unassigned] [Bug 157907] Web Inspector: Snapshots should be cleared at some point

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=157907

--- Comment #6 from Brian Burg <bburg at apple.com> ---
Comment on attachment 281793
  --> https://bugs.webkit.org/attachment.cgi?id=281793
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=281793&action=review

Code change looks good. I am a little concerned that this policy will be too aggressive for multi-navigation recordings, but I guess we can wait and see if this turns out to be a problem in practice. (I think it would be more intuitive if we drop snapshots when the recording becomes non-active.)

> Source/WebCore/inspector/PageHeapAgent.cpp:56
> +} // namespace WebCore

Trailing newline?

> Source/WebInspectorUI/UserInterface/Proxies/HeapSnapshotWorkerProxy.js:103
> +        this.clearSnapshots(function() {

arrow function?

> Source/WebInspectorUI/UserInterface/Proxies/HeapSnapshotWorkerProxy.js:117
> +        // Error.

Comment here does not add anything.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160623/7e1c6e6a/attachment.html>