[Webkit-unassigned] [Bug 157907] Web Inspector: Snapshots should be cleared at some point

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=157907

Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #281793|review?                     |review+
              Flags|                            |

--- Comment #5 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 281793
  --> https://bugs.webkit.org/attachment.cgi?id=281793
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=281793&action=review

> Source/JavaScriptCore/inspector/agents/InspectorHeapAgent.h:59
> +    void gc(ErrorString&) override final;
> +    void snapshot(ErrorString&, double* timestamp, String* snapshotData) override final;
> +    void startTracking(ErrorString&) override final;
> +    void stopTracking(ErrorString&) override final;
> +    void getPreview(ErrorString&, int heapObjectId, Inspector::Protocol::OptOutput<String>* resultString, RefPtr<Inspector::Protocol::Debugger::FunctionDetails>& functionDetails, RefPtr<Inspector::Protocol::Runtime::ObjectPreview>& objectPreview) override final;
> +    void getRemoteObject(ErrorString&, int heapObjectId, const String* optionalObjectGroup, RefPtr<Inspector::Protocol::Runtime::RemoteObject>& result) override final;

Just final.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160623/f688eb79/attachment.html>