<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Web Inspector: Snapshots should be cleared at some point"
   href="https://bugs.webkit.org/show_bug.cgi?id=157907#c6">Comment # 6</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Web Inspector: Snapshots should be cleared at some point"
   href="https://bugs.webkit.org/show_bug.cgi?id=157907">bug 157907</a>
              from <span class="vcard"><a class="email" href="mailto:bburg&#64;apple.com" title="Brian Burg &lt;bburg&#64;apple.com&gt;"> <span class="fn">Brian Burg</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=281793&amp;action=diff" name="attach_281793" title="[PATCH] Proposed Fix">attachment 281793</a> <a href="attachment.cgi?id=281793&amp;action=edit" title="[PATCH] Proposed Fix">[details]</a></span>
[PATCH] Proposed Fix

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=281793&amp;action=review">https://bugs.webkit.org/attachment.cgi?id=281793&amp;action=review</a>

Code change looks good. I am a little concerned that this policy will be too aggressive for multi-navigation recordings, but I guess we can wait and see if this turns out to be a problem in practice. (I think it would be more intuitive if we drop snapshots when the recording becomes non-active.)

<span class="quote">&gt; Source/WebCore/inspector/PageHeapAgent.cpp:56
&gt; +} // namespace WebCore</span >

Trailing newline?

<span class="quote">&gt; Source/WebInspectorUI/UserInterface/Proxies/HeapSnapshotWorkerProxy.js:103
&gt; +        this.clearSnapshots(function() {</span >

arrow function?

<span class="quote">&gt; Source/WebInspectorUI/UserInterface/Proxies/HeapSnapshotWorkerProxy.js:117
&gt; +        // Error.</span >

Comment here does not add anything.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>