<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:timothy@apple.com" title="Timothy Hatcher <timothy@apple.com>"> <span class="fn">Timothy Hatcher</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Snapshots should be cleared at some point"
href="https://bugs.webkit.org/show_bug.cgi?id=157907">bug 157907</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #281793 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Snapshots should be cleared at some point"
href="https://bugs.webkit.org/show_bug.cgi?id=157907#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Snapshots should be cleared at some point"
href="https://bugs.webkit.org/show_bug.cgi?id=157907">bug 157907</a>
from <span class="vcard"><a class="email" href="mailto:timothy@apple.com" title="Timothy Hatcher <timothy@apple.com>"> <span class="fn">Timothy Hatcher</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=281793&action=diff" name="attach_281793" title="[PATCH] Proposed Fix">attachment 281793</a> <a href="attachment.cgi?id=281793&action=edit" title="[PATCH] Proposed Fix">[details]</a></span>
[PATCH] Proposed Fix
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=281793&action=review">https://bugs.webkit.org/attachment.cgi?id=281793&action=review</a>
<span class="quote">> Source/JavaScriptCore/inspector/agents/InspectorHeapAgent.h:59
> + void gc(ErrorString&) override final;
> + void snapshot(ErrorString&, double* timestamp, String* snapshotData) override final;
> + void startTracking(ErrorString&) override final;
> + void stopTracking(ErrorString&) override final;
> + void getPreview(ErrorString&, int heapObjectId, Inspector::Protocol::OptOutput<String>* resultString, RefPtr<Inspector::Protocol::Debugger::FunctionDetails>& functionDetails, RefPtr<Inspector::Protocol::Runtime::ObjectPreview>& objectPreview) override final;
> + void getRemoteObject(ErrorString&, int heapObjectId, const String* optionalObjectGroup, RefPtr<Inspector::Protocol::Runtime::RemoteObject>& result) override final;</span >
Just final.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>