[Webkit-unassigned] [Bug 151303] WebRTC: Check type of this in RTCPeerConnection JS built-in functions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 16 01:01:06 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=151303

--- Comment #5 from youenn fablet <youennf at gmail.com> ---
(In reply to comment #4)
> (In reply to comment #3)
> > Would you be able to add 2 tests:
> > - Changing a RTCPeerConnection object prototype, then calling one of
> > RTCPeerConnection function on the object.
> > - Setting an object to the RTCPeerConnection prototype and calling one of
> > the methods.
> > 
> > Ideally we should not rely on the object prototype itself.
> 
> The current @isRTCPeerConnection() cannot deal with the cases you describe
> Youenn. My initial thinking is to add a JSBuiltinConstructor where I can
> initialize the @operations field and use that one as a probe. Right now the
> existence for @operations is checked before every use, so a JS built-in
> constructor would be useful anyhow.

That would probably cover the cases.

In the future we might want to make checks more uniform, for instance something like:
if (!(object instanceof @RTCPeerConnection))
   throw new @TypeError(...)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160616/f36379ef/attachment-0001.html>


More information about the webkit-unassigned mailing list