[Webkit-unassigned] [Bug 151303] WebRTC: Check type of this in RTCPeerConnection JS built-in functions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 16 00:17:24 PDT 2016


--- Comment #4 from Adam Bergkvist <adam.bergkvist at ericsson.com> ---
(In reply to comment #3)
> Would you be able to add 2 tests:
> - Changing a RTCPeerConnection object prototype, then calling one of
> RTCPeerConnection function on the object.
> - Setting an object to the RTCPeerConnection prototype and calling one of
> the methods.
> Ideally we should not rely on the object prototype itself.

The current @isRTCPeerConnection() cannot deal with the cases you describe Youenn. My initial thinking is to add a JSBuiltinConstructor where I can initialize the @operations field and use that one as a probe. Right now the existence for @operations is checked before every use, so a JS built-in constructor would be useful anyhow.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160616/e447460d/attachment.html>

More information about the webkit-unassigned mailing list