<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: Check type of this in RTCPeerConnection JS built-in functions"
href="https://bugs.webkit.org/show_bug.cgi?id=151303#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: Check type of this in RTCPeerConnection JS built-in functions"
href="https://bugs.webkit.org/show_bug.cgi?id=151303">bug 151303</a>
from <span class="vcard"><a class="email" href="mailto:youennf@gmail.com" title="youenn fablet <youennf@gmail.com>"> <span class="fn">youenn fablet</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=151303#c4">comment #4</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=151303#c3">comment #3</a>)
> > Would you be able to add 2 tests:
> > - Changing a RTCPeerConnection object prototype, then calling one of
> > RTCPeerConnection function on the object.
> > - Setting an object to the RTCPeerConnection prototype and calling one of
> > the methods.
> >
> > Ideally we should not rely on the object prototype itself.
>
> The current @isRTCPeerConnection() cannot deal with the cases you describe
> Youenn. My initial thinking is to add a JSBuiltinConstructor where I can
> initialize the @operations field and use that one as a probe. Right now the
> existence for @operations is checked before every use, so a JS built-in
> constructor would be useful anyhow.</span >
That would probably cover the cases.
In the future we might want to make checks more uniform, for instance something like:
if (!(object instanceof @RTCPeerConnection))
throw new @TypeError(...)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>