[Webkit-unassigned] [Bug 158621] WebRTC: Add test that verifies that RTCPeerConnection.addTrack can reuse an existing RTCRtpSender

Mon Jun 13 03:02:01 PDT 2016

https://bugs.webkit.org/show_bug.cgi?id=158621

--- Comment #3 from Adam Bergkvist <adam.bergkvist at ericsson.com> ---
(In reply to comment #2)
> Comment on attachment 281013 [details]
> Proposed patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=281013&action=review
> 
> > LayoutTests/fast/mediastream/RTCPeerConnection-addTrack-reuse-sender.html:1
> > +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
> 
> I just noticed that you are using the HTML 2.0 doctype for these tests. Why
> not just "<!DOCTYPE html>"?

I had not noticed that, but you're right. I based this on some other test which had this old doctype. Fixed now.

> > LayoutTests/fast/mediastream/RTCPeerConnection-addTrack-reuse-sender.html:52
> > +                debug("");
> 
> Minor nit: you can get rid of all debug("")s by adding a '<br>' to the
> beginning of the next debug string.

Let's use that. Fixed.

> > LayoutTests/fast/mediastream/RTCPeerConnection-addTrack-reuse-sender.html:58
> > +                debug("*** An extra sender should have been added");
> 
> Another minor nit: why no blank line before this?

These lines belong to the same chunk as the ones above. I can see that the initial "***" on debug messages makes them look like "headers". I borrowed that style from some other test to highlight debug messages.

> > LayoutTests/fast/mediastream/RTCPeerConnection-addTrack-reuse-sender.html:69
> > +                debug("*** The number of senders should not have changed");
> 
> Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160613/27ddb82c/attachment.html>