<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: Add test that verifies that RTCPeerConnection.addTrack can reuse an existing RTCRtpSender"
href="https://bugs.webkit.org/show_bug.cgi?id=158621#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: Add test that verifies that RTCPeerConnection.addTrack can reuse an existing RTCRtpSender"
href="https://bugs.webkit.org/show_bug.cgi?id=158621">bug 158621</a>
from <span class="vcard"><a class="email" href="mailto:adam.bergkvist@ericsson.com" title="Adam Bergkvist <adam.bergkvist@ericsson.com>"> <span class="fn">Adam Bergkvist</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=158621#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=281013&action=diff" name="attach_281013" title="Proposed patch">attachment 281013</a> <a href="attachment.cgi?id=281013&action=edit" title="Proposed patch">[details]</a></span>
> Proposed patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=281013&action=review">https://bugs.webkit.org/attachment.cgi?id=281013&action=review</a>
>
> > LayoutTests/fast/mediastream/RTCPeerConnection-addTrack-reuse-sender.html:1
> > +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
>
> I just noticed that you are using the HTML 2.0 doctype for these tests. Why
> not just "<!DOCTYPE html>"?</span >
I had not noticed that, but you're right. I based this on some other test which had this old doctype. Fixed now.
<span class="quote">> > LayoutTests/fast/mediastream/RTCPeerConnection-addTrack-reuse-sender.html:52
> > + debug("");
>
> Minor nit: you can get rid of all debug("")s by adding a '<br>' to the
> beginning of the next debug string.</span >
Let's use that. Fixed.
<span class="quote">> > LayoutTests/fast/mediastream/RTCPeerConnection-addTrack-reuse-sender.html:58
> > + debug("*** An extra sender should have been added");
>
> Another minor nit: why no blank line before this?</span >
These lines belong to the same chunk as the ones above. I can see that the initial "***" on debug messages makes them look like "headers". I borrowed that style from some other test to highlight debug messages.
<span class="quote">> > LayoutTests/fast/mediastream/RTCPeerConnection-addTrack-reuse-sender.html:69
> > + debug("*** The number of senders should not have changed");
>
> Ditto.</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>