[Webkit-unassigned] [Bug 158621] WebRTC: Add test that verifies that RTCPeerConnection.addTrack can reuse an existing RTCRtpSender

Fri Jun 10 10:37:58 PDT 2016

https://bugs.webkit.org/show_bug.cgi?id=158621

--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 281013
  --> https://bugs.webkit.org/attachment.cgi?id=281013
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281013&action=review

> LayoutTests/fast/mediastream/RTCPeerConnection-addTrack-reuse-sender.html:1
> +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

I just noticed that you are using the HTML 2.0 doctype for these tests. Why not just "<!DOCTYPE html>"?

> LayoutTests/fast/mediastream/RTCPeerConnection-addTrack-reuse-sender.html:52
> +                debug("");

Minor nit: you can get rid of all debug("")s by adding a '<br>' to the beginning of the next debug string.

> LayoutTests/fast/mediastream/RTCPeerConnection-addTrack-reuse-sender.html:58
> +                debug("*** An extra sender should have been added");

Another minor nit: why no blank line before this?

> LayoutTests/fast/mediastream/RTCPeerConnection-addTrack-reuse-sender.html:69
> +                debug("*** The number of senders should not have changed");

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160610/bd253db3/attachment.html>