[Webkit-unassigned] [Bug 158634] AX: Form label text should be exposed as static text if it contains only static text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=158634

--- Comment #10 from Doug Russell <d_russell at apple.com> ---
Comment on attachment 281067
  --> https://bugs.webkit.org/attachment.cgi?id=281067
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281067&action=review

>> Source/WebCore/CMakeLists.txt:1049
>> +    accessibility/AccessibilityLabel.cpp
> 
> Do we need to all to AccessibilityAllInOne.cpp for windows builds?

I believe so. I could try submitting the patch without it.

>> Source/WebCore/accessibility/AccessibilityLabel.h:46
>> +    AccessibilityRole roleValue() const final { return LabelRole; }
> 
> These should have the override keyword on them? Or does final take care of that

My understanding is that final implies override.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160611/f81a6511/attachment.html>