[Webkit-unassigned] [Bug 158634] AX: Form label text should be exposed as static text if it contains only static text

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 10 17:51:53 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=158634

--- Comment #9 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 281067
  --> https://bugs.webkit.org/attachment.cgi?id=281067
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281067&action=review

> Source/WebCore/CMakeLists.txt:1049
> +    accessibility/AccessibilityLabel.cpp

Do we need to all to AccessibilityAllInOne.cpp for windows builds?

> Source/WebCore/accessibility/AccessibilityLabel.h:46
> +    AccessibilityRole roleValue() const final { return LabelRole; }

These should have the override keyword on them? Or does final take care of that

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160611/224bf2c7/attachment-0001.html>


More information about the webkit-unassigned mailing list