<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Form label text should be exposed as static text if it contains only static text"
href="https://bugs.webkit.org/show_bug.cgi?id=158634#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Form label text should be exposed as static text if it contains only static text"
href="https://bugs.webkit.org/show_bug.cgi?id=158634">bug 158634</a>
from <span class="vcard"><a class="email" href="mailto:d_russell@apple.com" title="Doug Russell <d_russell@apple.com>"> <span class="fn">Doug Russell</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=281067&action=diff" name="attach_281067" title="Patch">attachment 281067</a> <a href="attachment.cgi?id=281067&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=281067&action=review">https://bugs.webkit.org/attachment.cgi?id=281067&action=review</a>
<span class="quote">>> Source/WebCore/CMakeLists.txt:1049
>> + accessibility/AccessibilityLabel.cpp
>
> Do we need to all to AccessibilityAllInOne.cpp for windows builds?</span >
I believe so. I could try submitting the patch without it.
<span class="quote">>> Source/WebCore/accessibility/AccessibilityLabel.h:46
>> + AccessibilityRole roleValue() const final { return LabelRole; }
>
> These should have the override keyword on them? Or does final take care of that</span >
My understanding is that final implies override.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>