<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: Add test that verifies that RTCPeerConnection.addTrack can reuse an existing RTCRtpSender"
href="https://bugs.webkit.org/show_bug.cgi?id=158621#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: Add test that verifies that RTCPeerConnection.addTrack can reuse an existing RTCRtpSender"
href="https://bugs.webkit.org/show_bug.cgi?id=158621">bug 158621</a>
from <span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=281013&action=diff" name="attach_281013" title="Proposed patch">attachment 281013</a> <a href="attachment.cgi?id=281013&action=edit" title="Proposed patch">[details]</a></span>
Proposed patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=281013&action=review">https://bugs.webkit.org/attachment.cgi?id=281013&action=review</a>
<span class="quote">> LayoutTests/fast/mediastream/RTCPeerConnection-addTrack-reuse-sender.html:1
> +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"></span >
I just noticed that you are using the HTML 2.0 doctype for these tests. Why not just "<!DOCTYPE html>"?
<span class="quote">> LayoutTests/fast/mediastream/RTCPeerConnection-addTrack-reuse-sender.html:52
> + debug("");</span >
Minor nit: you can get rid of all debug("")s by adding a '<br>' to the beginning of the next debug string.
<span class="quote">> LayoutTests/fast/mediastream/RTCPeerConnection-addTrack-reuse-sender.html:58
> + debug("*** An extra sender should have been added");</span >
Another minor nit: why no blank line before this?
<span class="quote">> LayoutTests/fast/mediastream/RTCPeerConnection-addTrack-reuse-sender.html:69
> + debug("*** The number of senders should not have changed");</span >
Ditto.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>