[Webkit-unassigned] [Bug 158564] [Threaded Compositor] Content and viewport sizes are mixed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=158564

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #3)
> Comment on attachment 280916 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=280916&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:143
> > +void ThreadedCoordinatedLayerTreeHost::contentsSizeChanged(const WebCore::IntSize& newSize)
> 
> I like this change which makes more clear.
> 
> > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:172
> > +void ThreadedCoordinatedLayerTreeHost::sizeDidChange(const WebCore::IntSize& size)
> 
> But I think it would be better to use viewportSizeChanged, which provide
> more clear idea.
> In this change, we will send same size to the CompositingCoordinator and
> Compositor which implies
> our contents size and viewport sile will be same all the time.
> But it is not true when we are in the fixed layout.

Current code is what is confusing, because it uses a different name than all other LayerTreeHost implementation, and requires to add #ifdefed code to the drawing area code. There's a check to only update the size when the contents size changes in case of fixed layout.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160610/0afda4c5/attachment.html>