[Webkit-unassigned] [Bug 158564] [Threaded Compositor] Content and viewport sizes are mixed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 10 05:24:21 PDT 2016


--- Comment #3 from Gwang Yoon Hwang <yoon at igalia.com> ---
Comment on attachment 280916
  --> https://bugs.webkit.org/attachment.cgi?id=280916

View in context: https://bugs.webkit.org/attachment.cgi?id=280916&action=review

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:143
> +void ThreadedCoordinatedLayerTreeHost::contentsSizeChanged(const WebCore::IntSize& newSize)

I like this change which makes more clear.

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:172
> +void ThreadedCoordinatedLayerTreeHost::sizeDidChange(const WebCore::IntSize& size)

But I think it would be better to use viewportSizeChanged, which provide more clear idea.
In this change, we will send same size to the CompositingCoordinator and Compositor which implies
our contents size and viewport sile will be same all the time.
But it is not true when we are in the fixed layout.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160610/eaf74a1c/attachment-0001.html>

More information about the webkit-unassigned mailing list