<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Threaded Compositor] Content and viewport sizes are mixed"
href="https://bugs.webkit.org/show_bug.cgi?id=158564#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Threaded Compositor] Content and viewport sizes are mixed"
href="https://bugs.webkit.org/show_bug.cgi?id=158564">bug 158564</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=158564#c3">comment #3</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=280916&action=diff" name="attach_280916" title="Patch">attachment 280916</a> <a href="attachment.cgi?id=280916&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=280916&action=review">https://bugs.webkit.org/attachment.cgi?id=280916&action=review</a>
>
> > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:143
> > +void ThreadedCoordinatedLayerTreeHost::contentsSizeChanged(const WebCore::IntSize& newSize)
>
> I like this change which makes more clear.
>
> > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:172
> > +void ThreadedCoordinatedLayerTreeHost::sizeDidChange(const WebCore::IntSize& size)
>
> But I think it would be better to use viewportSizeChanged, which provide
> more clear idea.
> In this change, we will send same size to the CompositingCoordinator and
> Compositor which implies
> our contents size and viewport sile will be same all the time.
> But it is not true when we are in the fixed layout.</span >
Current code is what is confusing, because it uses a different name than all other LayerTreeHost implementation, and requires to add #ifdefed code to the drawing area code. There's a check to only update the size when the contents size changes in case of fixed layout.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>