[Webkit-unassigned] [Bug 160237] Split calculateCacheSizes in two methods

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160237

--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #6)
> Comment on attachment 284758 [details]
> Updated patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=284758&action=review
> 
> > Source/WebCore/platform/mac/FileSystemMac.mm:105
> > +    NSDictionary *fileSystemAttributesDictionary = [[NSFileManager defaultManager] attributesOfFileSystemForPath:(NSString *)path error:NULL];
> > +    freeSpace = [[fileSystemAttributesDictionary objectForKey:NSFileSystemFreeSize] unsignedLongLongValue];
> > +    return true;
> 
> If fileSystemAttributesDictionary is nil, then the function failed, and
> should return false.

Ah, ok.

> It’s funny that Apple API uses the term "file system free size", the same
> term I asked you to stop using here!

Yes, I guess that's where the original function name came from actually, I just added the ForPath suffix to make it even worse :-P

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160729/49b6feb6/attachment.html>