<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Split calculateCacheSizes in two methods"
href="https://bugs.webkit.org/show_bug.cgi?id=160237#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Split calculateCacheSizes in two methods"
href="https://bugs.webkit.org/show_bug.cgi?id=160237">bug 160237</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=160237#c6">comment #6</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=284758&action=diff" name="attach_284758" title="Updated patch">attachment 284758</a> <a href="attachment.cgi?id=284758&action=edit" title="Updated patch">[details]</a></span>
> Updated patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=284758&action=review">https://bugs.webkit.org/attachment.cgi?id=284758&action=review</a>
>
> > Source/WebCore/platform/mac/FileSystemMac.mm:105
> > + NSDictionary *fileSystemAttributesDictionary = [[NSFileManager defaultManager] attributesOfFileSystemForPath:(NSString *)path error:NULL];
> > + freeSpace = [[fileSystemAttributesDictionary objectForKey:NSFileSystemFreeSize] unsignedLongLongValue];
> > + return true;
>
> If fileSystemAttributesDictionary is nil, then the function failed, and
> should return false.</span >
Ah, ok.
<span class="quote">> It’s funny that Apple API uses the term "file system free size", the same
> term I asked you to stop using here!</span >
Yes, I guess that's where the original function name came from actually, I just added the ForPath suffix to make it even worse :-P</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>