[Webkit-unassigned] [Bug 160237] Split calculateCacheSizes in two methods

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160237

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #284758|review?                     |review+
              Flags|                            |

--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 284758
  --> https://bugs.webkit.org/attachment.cgi?id=284758
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284758&action=review

> Source/WebCore/platform/mac/FileSystemMac.mm:105
> +    NSDictionary *fileSystemAttributesDictionary = [[NSFileManager defaultManager] attributesOfFileSystemForPath:(NSString *)path error:NULL];
> +    freeSpace = [[fileSystemAttributesDictionary objectForKey:NSFileSystemFreeSize] unsignedLongLongValue];
> +    return true;

If fileSystemAttributesDictionary is nil, then the function failed, and should return false.

It’s funny that Apple API uses the term "file system free size", the same term I asked you to stop using here!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160728/8c780fca/attachment.html>