<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Split calculateCacheSizes in two methods"
href="https://bugs.webkit.org/show_bug.cgi?id=160237">bug 160237</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #284758 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Split calculateCacheSizes in two methods"
href="https://bugs.webkit.org/show_bug.cgi?id=160237#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Split calculateCacheSizes in two methods"
href="https://bugs.webkit.org/show_bug.cgi?id=160237">bug 160237</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=284758&action=diff" name="attach_284758" title="Updated patch">attachment 284758</a> <a href="attachment.cgi?id=284758&action=edit" title="Updated patch">[details]</a></span>
Updated patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=284758&action=review">https://bugs.webkit.org/attachment.cgi?id=284758&action=review</a>
<span class="quote">> Source/WebCore/platform/mac/FileSystemMac.mm:105
> + NSDictionary *fileSystemAttributesDictionary = [[NSFileManager defaultManager] attributesOfFileSystemForPath:(NSString *)path error:NULL];
> + freeSpace = [[fileSystemAttributesDictionary objectForKey:NSFileSystemFreeSize] unsignedLongLongValue];
> + return true;</span >
If fileSystemAttributesDictionary is nil, then the function failed, and should return false.
It’s funny that Apple API uses the term "file system free size", the same term I asked you to stop using here!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>