[Webkit-unassigned] [Bug 159463] [GTK] Avoid the redirected window resize when the view is realized in AC mode

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 21 00:04:51 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=159463

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #4)
> Comment on attachment 282881 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=282881&action=review
> 
> > Source/WebKit2/ChangeLog:18
> > +        WebPageProxy the redirected window has access to the devide scale factor and view widget to get the parent
> 
> device
> 
> > Source/WebKit2/ChangeLog:26
> > +        (WebKit::RedirectedXCompositeWindow::~RedirectedXCompositeWindow): Deleted.
> 
> prepare-ChangeLog bug
> 
> > Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.cpp:140
> > +    return std::unique_ptr<RedirectedXCompositeWindow>(new RedirectedXCompositeWindow(webPage, initialSize, WTFMove(damageNotify)));
> 
> Since you modified this line anyway, change it to use std::make_unique while
> you're at it, please. Using new outside of a create function is not OK
> anymore.

This is the create() function and the constructor is private.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160721/a4458bb0/attachment.html>


More information about the webkit-unassigned mailing list