<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Avoid the redirected window resize when the view is realized in AC mode"
href="https://bugs.webkit.org/show_bug.cgi?id=159463#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Avoid the redirected window resize when the view is realized in AC mode"
href="https://bugs.webkit.org/show_bug.cgi?id=159463">bug 159463</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=159463#c4">comment #4</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=282881&action=diff" name="attach_282881" title="Patch">attachment 282881</a> <a href="attachment.cgi?id=282881&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=282881&action=review">https://bugs.webkit.org/attachment.cgi?id=282881&action=review</a>
>
> > Source/WebKit2/ChangeLog:18
> > + WebPageProxy the redirected window has access to the devide scale factor and view widget to get the parent
>
> device
>
> > Source/WebKit2/ChangeLog:26
> > + (WebKit::RedirectedXCompositeWindow::~RedirectedXCompositeWindow): Deleted.
>
> prepare-ChangeLog bug
>
> > Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.cpp:140
> > + return std::unique_ptr<RedirectedXCompositeWindow>(new RedirectedXCompositeWindow(webPage, initialSize, WTFMove(damageNotify)));
>
> Since you modified this line anyway, change it to use std::make_unique while
> you're at it, please. Using new outside of a create function is not OK
> anymore.</span >
This is the create() function and the constructor is private.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>