[Webkit-unassigned] [Bug 159463] [GTK] Avoid the redirected window resize when the view is realized in AC mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159463

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #282881|review?                     |review+
              Flags|                            |

--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 282881
  --> https://bugs.webkit.org/attachment.cgi?id=282881
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282881&action=review

> Source/WebKit2/ChangeLog:18
> +        WebPageProxy the redirected window has access to the devide scale factor and view widget to get the parent

device

> Source/WebKit2/ChangeLog:26
> +        (WebKit::RedirectedXCompositeWindow::~RedirectedXCompositeWindow): Deleted.

prepare-ChangeLog bug

> Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.cpp:140
> +    return std::unique_ptr<RedirectedXCompositeWindow>(new RedirectedXCompositeWindow(webPage, initialSize, WTFMove(damageNotify)));

Since you modified this line anyway, change it to use std::make_unique while you're at it, please. Using new outside of a create function is not OK anymore.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160721/e5542d93/attachment-0001.html>