[Webkit-unassigned] [Bug 159552] [GStreamer][GL] crash within triggerRepaint

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 12 23:56:37 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=159552

--- Comment #11 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #8)
> Committed r203056: <http://trac.webkit.org/changeset/203056>

Landed patch is not correct, the advantage of using the MainThreadNotifier is that you don't need to care about creating a weak ptr, nor checking the caller thread. MainThreadNotifier has its own weak ptr and it's destroyed by the media player private class destructor, so you don't need to move the weak ptr factory either. You just need to add the new notification to the enum and then 

- m_player->sizeChanged();
+ m_notifier.notify(MainThreadNotification::SizeChanged, [this] { m_player->sizeChanged() });

That's all

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160713/32c00c83/attachment.html>


More information about the webkit-unassigned mailing list