<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [GStreamer][GL] crash within triggerRepaint"
href="https://bugs.webkit.org/show_bug.cgi?id=159552#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [GStreamer][GL] crash within triggerRepaint"
href="https://bugs.webkit.org/show_bug.cgi?id=159552">bug 159552</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=159552#c8">comment #8</a>)
<span class="quote">> Committed r203056: <<a href="http://trac.webkit.org/changeset/203056">http://trac.webkit.org/changeset/203056</a>></span >
Landed patch is not correct, the advantage of using the MainThreadNotifier is that you don't need to care about creating a weak ptr, nor checking the caller thread. MainThreadNotifier has its own weak ptr and it's destroyed by the media player private class destructor, so you don't need to move the weak ptr factory either. You just need to add the new notification to the enum and then
- m_player->sizeChanged();
+ m_notifier.notify(MainThreadNotification::SizeChanged, [this] { m_player->sizeChanged() });
That's all</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>